This repository was archived by the owner on Mar 5, 2026. It is now read-only.
Move Client @connection to its own, independent method#7
Merged
zph merged 2 commits intobufferapp:masterfrom Dec 23, 2018
vierarb:master
Merged
Move Client @connection to its own, independent method#7zph merged 2 commits intobufferapp:masterfrom vierarb:master
zph merged 2 commits intobufferapp:masterfrom
vierarb:master
Conversation
zph
suggested changes
Dec 23, 2018
zph
left a comment
zph
left a comment
There was a problem hiding this comment.
Generally looks good. Thanks for the PR 👍 .
I left a question about the use case for attr_accessor :connection and will be happy to merge once that's answered/tweaked.
| include Info | ||
|
|
||
| attr_accessor :access_token | ||
| attr_accessor :access_token, :connection |
There was a problem hiding this comment.
Why add this attr_accessor when also defining the connection method? Do you have a use case that requires assigning into @connection?
If that's the case, please revise this to be attr_writer :connection
Author
There was a problem hiding this comment.
You are right, it's not necessary
zph
approved these changes
Dec 23, 2018
|
Looks good. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.