Repository navigation
Conversation
faritowich
reviewed
Jan 29, 2024
| TradingCalculator tradingCalculator = new TradingCalculator(amountOfPeople); | ||
| tradingCalculator.calculateAndDisp(); | ||
| } | ||
| } |
There was a problem hiding this comment.
По хорошему надо выносить всю эту логику из класса Main. Этот класс обычно призван только стартануть программу, а все остальное должно быть сделано в специальных классах.
| return rubles + " " + rublesText + " " + kopecks + " " + kopecksText; | ||
| } | ||
| } No newline at end of file | ||
| } |
There was a problem hiding this comment.
Отдельные классы лучше держать с отдельных файлах - это улучшает читаемость
|
|
||
| class TradingCalculator { | ||
| private double totalCost = 0.0; // итоговая стоимость | ||
| private int amountOfPeople; // количество человек |
| class TradingCalculator { | ||
| private double totalCost = 0.0; // итоговая стоимость | ||
| private int amountOfPeople; // количество человек | ||
| private List<String> productsList = new ArrayList<>(); |
| int kopecks = (int) ((amount - rubles) * 100); | ||
|
|
||
| String rublesText = ""; | ||
| String kopecksText = ""; |
There was a problem hiding this comment.
В данном случае нет необходимости присваивать начальные значение при объявлении
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👍