Skip to content

PUT /me - #52

Merged
foFox merged 2 commits into
developmentfrom
me-controller
Jul 25, 2013
Merged

foFox merged 2 commits into
developmentfrom
me-controller

Conversation

@tsov

@tsov tsov commented Jul 24, 2013

Copy link
Copy Markdown
Contributor

added MeController#update

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you want to user change the name. Let's leave it synced with Facebook.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, i dont know:D i'll remove it. I just hate facebook dependency!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know dependency is shit, but I think its easier for the other users, when the names of their friends on Eventhub are the same on Facebook. And since Facebook names are mostly real its better overall experience.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but what do we do if the user changes his name on facebook? Do you want to synch like friends? Thats gonna be expensive!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought assertion will sort it out, as when you log in, your name magically appears in our database. Can you not check the name when the user logs in ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by login? Do you mean registration? Yeah, on registration we take the name, but after that? What if you change your name on facebook? There is no easy way to determine if a user changed his username on facebook

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about if we do the same thing that we do with friends, if someone asks for users/1, you will return what you know and will kick off an update where u call Facebook, if the last update was more than 6 hours ago. For example. People do not change the name that often, so 6 hours threshold good I guess.

Maybe change your name on Facebook, and see how Spotify reacts to that.

I don't see how forcing the user to update the name manually makes it easy in any way on the user.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let me change this for now, then i will add friends + syncing 3rd party services

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an issue for that too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, are you getting redmine emails now?

foFox added a commit that referenced this pull request Jul 25, 2013
Do not forget to figure out how to sync the name with Facebook. I guess it is a similar issue to friends.
@foFox
foFox merged commit e35ab81 into development Jul 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants