Repository navigation
Conversation
…new stuff to readme to explain the authentication process.
There was a problem hiding this comment.
here i would suggest nested resources
resources :groups do
resources :members, :controller => 'group_members'
endso the GroupMembersController will
- show all the members of the group on action index
- show one member based on GroupMember model id on action show
- create a new GroupMember model on action create
- delete a GroupMember model on action delete
Same with the pending members
What do you think?
There was a problem hiding this comment.
isn't this a bit of an overkill to have a separate controller ? I would just stick in in there.
There was a problem hiding this comment.
actually I gave it a thought, and you might be right, i'll do it that way
There was a problem hiding this comment.
Yeah, i think its the better way to do it. I think there is something on railscasts too
|
Sweet! Is this updated? Sorry for all those stupid comments of mine |
There was a problem hiding this comment.
Yo! I like this a lot !
The let method is definitely something we should use more often!
There was a problem hiding this comment.
leave the return statements out, remember last line will automatically be returned in ruby
…-api into adding_groups_controller Conflicts: Gemfile README.rdoc app/controllers/application_controller.rb finished group controller tests, added spec files for pending & members
There was a problem hiding this comment.
this is deprecated, we need to use: let(:token) { double :accessible? => true, :resource_owner_id => owner_id } instead
I think thats why jenkins is failing too
|
Yo, how far is this? |
|
I think the test are bit shit, I think I got lost on how to test this, as there's so many possibilities, if you want we can remove then and start again. |
|
There are not shit, but very extensive.. Thats what happens if you do everything at once :D 28 commits, >2000 lines added. The tests seems more like regression tests, and look nothing like the tests we have. |
|
Otherwise, how far are you on this? |
|
We can scrap them if you want :P |
I added basic REST methods do groups controller