Skip to content

Use bqscales#904

Merged
martinRenou merged 1 commit intobqplot:masterfrom
martinRenou:scale
Aug 25, 2021
Merged

Use bqscales#904
martinRenou merged 1 commit intobqplot:masterfrom
martinRenou:scale

Conversation

@martinRenou
Copy link
Copy Markdown
Member

@martinRenou martinRenou commented Sep 13, 2019 •
edited
Loading

Remove all scales from bqplot and use bqscales instead.

Improvements ideas for when the scales are in a separate package:

  • make use of https://github.com/d3/d3-scale-chromatic it contains the same color schemes as what's currently available in bqplot and more.
  • have a ColorMap/ColorAxis widget (a bit like the ColorAxis widget from bqplot, but that would not require a Figure for being displayed). This would allow other libraries that will use the scales to display a color-map. Maybe make use of https://github.com/vidartf/chromabar which also uses d3-scale-chromatic

@martinRenou
Copy link
Copy Markdown
Member Author

martinRenou commented Sep 16, 2019

@SylvainCorlay @maartenbreddels @JohanMabille would you like to review this PR?

@martinRenou
Copy link
Copy Markdown
Member Author

martinRenou commented Sep 16, 2019

More changes coming actually. I'm using more strict TypeScript rules locally.

@martinRenou martinRenou force-pushed the scale branch 3 times, most recently from 4a63f75 to f862fa6 Compare September 24, 2019 13:59
@martinRenou martinRenou force-pushed the scale branch 4 times, most recently from 4a04f45 to a27f2dd Compare December 17, 2019 09:17
@martinRenou martinRenou changed the title [WIP] - Exporting scales from bqplot Exporting scales from bqplot Dec 17, 2019
@martinRenou
Copy link
Copy Markdown
Member Author

martinRenou commented Dec 17, 2019

@maartenbreddels @JohanMabille Would you mind giving it a review?

JohanMabille
JohanMabille reviewed Dec 17, 2019
View reviewed changes
Comment thread js/src/ScatterBase.ts Outdated
@martinRenou martinRenou force-pushed the scale branch 4 times, most recently from 3edfb13 to 4f3744d Compare December 17, 2019 12:26
@martinRenou martinRenou force-pushed the scale branch 5 times, most recently from 38906b9 to 397ee8f Compare January 26, 2021 15:55
@martinRenou martinRenou changed the title Exporting scales from bqplot Use bqscales Jan 26, 2021
@martinRenou martinRenou marked this pull request as draft January 26, 2021 16:57
@martinRenou
Copy link
Copy Markdown
Member Author

martinRenou commented Jan 26, 2021

Even though the tests are passing, this is not yet working due to a runtime issue in bqscales, I will fix it.

@martinRenou martinRenou force-pushed the scale branch 3 times, most recently from 0d4f7ba to d07bd54 Compare January 28, 2021 16:56
@martinRenou martinRenou marked this pull request as ready for review January 28, 2021 17:13
@martinRenou
Copy link
Copy Markdown
Member Author

martinRenou commented Jan 28, 2021

This PR is ready for review

@martinRenou martinRenou marked this pull request as draft August 20, 2021 13:07
@martinRenou martinRenou force-pushed the scale branch 5 times, most recently from f0fcd57 to fcff33d Compare August 20, 2021 14:11
@martinRenou martinRenou reopened this Aug 20, 2021
@martinRenou
Copy link
Copy Markdown
Member Author

martinRenou commented Aug 20, 2021

Trigerring CI

@martinRenou martinRenou mentioned this pull request Aug 24, 2021
Merged
@martinRenou martinRenou force-pushed the scale branch 2 times, most recently from 27b6015 to afffb69 Compare August 24, 2021 12:29
@martinRenou
Copy link
Copy Markdown
Member Author

martinRenou commented Aug 24, 2021

kicking CI

@martinRenou martinRenou reopened this Aug 24, 2021
@martinRenou martinRenou reopened this Aug 24, 2021
@martinRenou martinRenou force-pushed the scale branch 3 times, most recently from fc435a0 to d2bae36 Compare August 25, 2021 07:53
@martinRenou martinRenou marked this pull request as ready for review August 25, 2021 08:10
@martinRenou martinRenou reopened this Aug 25, 2021
@martinRenou martinRenou reopened this Aug 25, 2021
@martinRenou martinRenou merged commit 8bb2279 into bqplot:master Aug 25, 2021
@martinRenou martinRenou deleted the scale branch August 25, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohanMabille JohanMabille JohanMabille left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martinRenou @JohanMabille