fix: background color of figure was not computed properly#1603
Merged
martinRenou merged 1 commit intobqplot:0.12.xfrom Jul 11, 2023
Merged
fix: background color of figure was not computed properly#1603martinRenou merged 1 commit intobqplot:0.12.xfrom
martinRenou merged 1 commit intobqplot:0.12.xfrom
Conversation
Member
Author
|
Note that before we would get a different background color in voila and notebook because of style definitions on body. Now we get a white background color for both! :) |
On the screen, it is not the computed background color that is seen by a user. Since DOM elements can be transparent, the background color might be one of the parent elements. This is why we need to traverse the DOM tree to find the background color of the first non-transparent parent element. A more sophisticated solution would be to also use blending when there is a non-fully transparent background color. I think that might be a bit overkill for now. See also spacetelescope/jdaviz#2264 (comment)
maartenbreddels
force-pushed
the
fix_background_color_image
branch
from
084b79c to
ec48175
Compare
Member
|
meeseeksdev please backport to master |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
martinRenou
pushed a commit
to martinRenou/bqplot
that referenced
this pull request
Jul 11, 2023
On the screen, it is not the computed background color that is seen by a user. Since DOM elements can be transparent, the background color might be one of the parent elements. This is why we need to traverse the DOM tree to find the background color of the first non-transparent parent element. A more sophisticated solution would be to also use blending when there is a non-fully transparent background color. I think that might be a bit overkill for now. See also spacetelescope/jdaviz#2264 (comment)
martinRenou
added a commit
that referenced
this pull request
Jul 11, 2023
) On the screen, it is not the computed background color that is seen by a user. Since DOM elements can be transparent, the background color might be one of the parent elements. This is why we need to traverse the DOM tree to find the background color of the first non-transparent parent element. A more sophisticated solution would be to also use blending when there is a non-fully transparent background color. I think that might be a bit overkill for now. See also spacetelescope/jdaviz#2264 (comment) Co-authored-by: Maarten Breddels <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the screen, it is not the computed background color that is seen by a user. Since DOM elements can be transparent, the background color might be one of the parent elements. This is why we need to traverse the DOM tree to find the background color of the first non-transparent parent element.
A more sophisticated solution would be to also use blending when there is a non-fully transparent background color. I think that might be a bit overkill for now.
See also spacetelescope/jdaviz#2264 (comment)