Backport PR #1539: fix: figure is not updating when margins change#1581
Merged
maartenbreddels merged 1 commit intobqplot:0.12.xfrom Mar 14, 2023
Merged
Conversation
Member
|
@martinRenou what do you think, should we port https://github.com/bqplot/bqplot/pull/1550/files to 0.12.x? |
Member
|
Yes we should backport some of the recent PRs, I can look into it |
maartenbreddels
force-pushed
the
auto-backport-of-pr-1539-on-0.12.x
branch
from
cb603ed to
ab70701
Compare
Member
|
@mariobuikhuizen needs a prettifier run @martinRenou maybe we should let the rest of CI run, even if prettifier fails (so it's a sub step), and maybe have pre commit.. ? |
mariobuikhuizen
force-pushed
the
auto-backport-of-pr-1539-on-0.12.x
branch
from
ab70701 to
c7d8b95
Compare
Member
|
awesome! |
Contributor
|
Do you remember which Jdaviz ticket this was supposed to fix? I lost track. 😬 |
Contributor
Author
|
It's this one: spacetelescope/jdaviz#1671. |
Contributor
|
Great, thanks! Can you please let us know when this patch is released and we can then update the bqplot pin downstream? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Code changes
User-facing changes
Backwards-incompatible changes