Merged
Conversation
Contributor
Author
pllim
approved these changes
Jul 16, 2022
Member
|
Thanks for the PR, Matt! For what it's worth, the pyplot interface was not
designed with for compatibility with matplotlib. It's an issue we want to
resolve for 1.x. Chakri can probably discuss it in more details as it's his
implementation
…On Sat, Jul 16, 2022, 15:18 P. L. Lim ***@***.***> wrote:
***@***.**** approved this pull request.
I like the new markers. Thanks!
Note to self: Open follow-up issue after this PR is merged to request "+"
to be changed to thin "+" sign and "P" (uppercase P) to be the current
"thick +" sign that is mapped to "+" symbol.
—
Reply to this email directly, view it on GitHub
<#1506 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFZICWMBJUCHCXD5EBH4HUTVUMYMZANCNFSM53YQXAUA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
Will dig into the visual regression test during the week. Looks like node is failing building node-pre-gyp for some reason. |
ibdafna
force-pushed
the
add-markers-x-and-+
branch
from
b1fd2aa to
25425e2
Compare
ibdafna
requested changes
Jul 21, 2022
Member
There was a problem hiding this comment.
@mwcraig Thanks again for this PR! 🤗
Would it be possible to make the addition consistent by adding the new marker annotations to the following places?
- https://github.com/mwcraig/bqplot/blob/25425e2dbfdc55eba081bf26516e6ab476ebbeeb/bqplot/marks.py#L330
- https://github.com/mwcraig/bqplot/blob/25425e2dbfdc55eba081bf26516e6ab476ebbeeb/bqplot/marks.py#L409
Also, an updated example in the Lines.ipynb (where we list the different available markers) notebook would be awesome!
And finally, once the notebook above is updated, we can add some visual regression testing via this PR. Thanks again! 💚
Contributor
Author
|
@ibdafna -- I've addressed the review comments. |
Member
|
meeseeksdev please backport to 0.12.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/bqplot
that referenced
this pull request
Sep 29, 2022
martinRenou
added a commit
that referenced
this pull request
Sep 29, 2022
…6-on-0.12.x Backport PR #1506 on branch 0.12.x (Add +, x and . as markers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Closes #1457
Code changes
See below
User-facing changes
This adds three more scatter marker shapes:
plus, which makes the shape+, with the shortcutpcrosshair, which makes the shape×, with the shortcutxpoint, which makes a small circle, with the shortcut.Backwards-incompatible changes
N/A