Skip to content

Fix CI#1440

Merged
martinRenou merged 1 commit intobqplot:masterfrom
martinRenou:fix_ci
Jan 19, 2022
Merged

Fix CI#1440
martinRenou merged 1 commit intobqplot:masterfrom
martinRenou:fix_ci

Conversation

@martinRenou
Copy link
Copy Markdown
Member

No description provided.

@martinRenou martinRenou force-pushed the fix_ci branch 4 times, most recently from f622f92 to e3ffe42 Compare January 19, 2022 13:41
@martinRenou
Copy link
Copy Markdown
Member Author

At first I was fixing the CI with setting the env variable: NODE_OPTIONS: --openssl-legacy-provider. But this only fixes the CI, not installing from source on user machine.

The second approach is taken from jupyterlab/jupyterlab#11249

@martinRenou martinRenou changed the title Try fixing CI Fix CI Jan 19, 2022
@martinRenou martinRenou merged commit 92ff004 into bqplot:master Jan 19, 2022
@martinRenou martinRenou deleted the fix_ci branch January 19, 2022 15:04
@martinRenou
Copy link
Copy Markdown
Member Author

meeseeksdev please backport to 0.12.x

@lumberbot-app
Copy link
Copy Markdown

lumberbot-app bot commented Feb 10, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 0.12.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 92ff00450ed206ad6ebf1c51a88099a406e154a7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1440: Fix CI'
  1. Push to a named branch:
git push YOURFORK 0.12.x:auto-backport-of-pr-1440-on-0.12.x
  1. Create a PR against branch 0.12.x, I would have named this PR:

"Backport PR #1440 on branch 0.12.x (Fix CI)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

martinRenou added a commit to martinRenou/bqplot that referenced this pull request Feb 10, 2022
martinRenou added a commit that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant