Fix index selector jumping back to 0#1426
Conversation
martinRenou
force-pushed
the
fix_index_selector_jumping
branch
from
2aab796 to
ab354a8
Compare
|
This needs a test with Galata that changes the selection from Python and takes a screenshot |
|
I added a Galata test that is properly exposing the bug this PR is fixing: Before
After
|
|
As discussed during the weekly bqplot meeting, there might be another issue that is making #1422 issue worse, related to some trait bouncing between the back-end and the front-end. Anyway this PR seems to fix #1422. I will investigate more on this trait bouncing and open a separate PR if I find another fix. |
martinRenou
force-pushed
the
fix_index_selector_jumping
branch
from
65fa796 to
ed3f3bf
Compare
|
@meeseeksdev please backport to 0.12.x |
|
Following up on the jumping issue. I don't seem to be able to reproduce the jumping (with the bqplot version prior to this PR) on a simple example like the one posted above. I seem to only reproduce the jumping in the code sample from the linked issue #1422. What I believe is happening there is that there are some overlapping scatter points, and the index selector doesn't know which point to select, so it's jumping from one to the other. And because it used to set the position of the line back to 0 when the selection changes it was jumping. |
…6-on-0.12.x Backport PR #1426 on branch 0.12.x (Fix index selector jumping back to 0)
1 participant
Fix #1422