feat: make a PNG export of the figure available in the kernel#1397
Merged
martinRenou merged 1 commit intobqplot:masterfrom Sep 30, 2021
Merged
feat: make a PNG export of the figure available in the kernel#1397martinRenou merged 1 commit intobqplot:masterfrom
martinRenou merged 1 commit intobqplot:masterfrom
Conversation
Member
|
LGTM, would like a 2nd opinion from @SylvainCorlay or @martinRenou on this. Some thoughts that don't need addressing perse:
|
martinRenou
force-pushed
the
feat_png_export_kernel
branch
from
1749522 to
d2382a9
Compare
Member
|
Rebased |
Member
|
@meeseeksdev backport to 0.12.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/bqplot
that referenced
this pull request
Sep 30, 2021
…ble in the kernel
Contributor
|
Thanks! Nice! Which release will this feature be in? 😸 |
Member
|
0.12.31 :) It should come soon |
martinRenou
added a commit
that referenced
this pull request
Sep 30, 2021
…7-on-0.12.x Backport PR #1397 on branch 0.12.x (feat: make a PNG export of the figure available in the kernel)
pllim
reviewed
Oct 11, 2021
| if self._upload_png_callback: | ||
| raise Exception('get_png_data already in progress') | ||
| self._upload_png_callback = callback | ||
| self.send({'type': 'upload_png', 'scale': scale}) |
Contributor
There was a problem hiding this comment.
Seems to work, though this thing gets stuck in display-less CI, so I cannot write a test for it. Any trick I need to know to write a Python unit test that calls this function?
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A solution for #1393
Usage: