Skip to content

fix: changing an interaction causes it to remove the old view twice#1391

Merged
maartenbreddels merged 2 commits intobqplot:masterfrom
maartenbreddels:fix_remove_interaction_view
Aug 24, 2021
Merged

fix: changing an interaction causes it to remove the old view twice#1391
maartenbreddels merged 2 commits intobqplot:masterfrom
maartenbreddels:fix_remove_interaction_view

Conversation

@maartenbreddels
Copy link
Copy Markdown
Member

Fixes #1359

This caused the event listener fix introduced in #1347 to be removed again.

@pllim
Copy link
Copy Markdown
Contributor

pllim commented Aug 3, 2021

I don't see this bug over at Imviz. Alas, I am unable to build this PR from source on Debian + WSL2 (it got stuck at yarn install forever), so I'll just have to trust you on this one... Or maybe other Jdaviz devs can vet this instead.

@rosteen
Copy link
Copy Markdown

rosteen commented Aug 3, 2021

I was also unable to reproduce the bug on release bqplot in Jdaviz, but I'm willing to trust that this line is useful. I was also getting errors trying to pip install the dev version, not sure what's up:

ValueError: missing files: ['share/jupyter/nbextensions/bqplot/index.js', 'share/jupyter/labextensions/bqplot/package.json']

@pllim
Copy link
Copy Markdown
Contributor

pllim commented Aug 3, 2021

@rosteen , I got those too but they went away (to be replaced by a different problem) after I installed yarn.

@rosteen
Copy link
Copy Markdown

rosteen commented Aug 3, 2021

I suspected that would be the case, I was being lazy and didn't want to muck about with yarn...

@pllim
Copy link
Copy Markdown
Contributor

pllim commented Aug 3, 2021

Re: yarn -- Indeed, if you muck around too much, you might get tangled. 😏

@rosteen
Copy link
Copy Markdown

rosteen commented Aug 3, 2021

Well, I can confirm this didn't break anything in Jdaviz at least.

@maartenbreddels maartenbreddels merged commit 1eb6d3b into bqplot:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notebook scrolls when zooming

3 participants