only call update_completion once when adding a character

thomasballinger · thomasballinger · commit 2d3499421451 · 2015-01-06T15:24:03.000-05:00
diff --git a/bpython/curtsiesfrontend/repl.py b/bpython/curtsiesfrontend/repl.py
@@ -753,9 +753,12 @@ def add_normal_character(self, char):
         if self.incremental_search_mode:
             self.add_to_incremental_search(char)
         else:
-            self.current_line = (self.current_line[:self.cursor_offset] +
-                                 char +
-                                 self.current_line[self.cursor_offset:])
+            self._set_current_line((self.current_line[:self.cursor_offset] +
+                                    char +
+                                    self.current_line[self.cursor_offset:]),
+                                    update_completion=False,
+                                    reset_rl_history=False,
+                                    clear_special_mode=False)
             self.cursor_offset += 1
         if self.config.cli_trim_prompts and self.current_line.startswith(self.ps1):
             self.current_line = self.current_line[4:]
@@ -1232,14 +1235,13 @@ def _get_cursor_offset(self):
     def _set_cursor_offset(self, offset, update_completion=True, reset_rl_history=False, clear_special_mode=True):
         if self._cursor_offset == offset:
             return
-        if update_completion:
-            self.update_completion()
         if reset_rl_history:
             self.rl_history.reset()
         if clear_special_mode:
             self.incremental_search_mode = None
         self._cursor_offset = offset
-        self.update_completion()
+        if update_completion:
+            self.update_completion()
         self.unhighlight_paren()
     cursor_offset = property(_get_cursor_offset, _set_cursor_offset, None,
                             "The current cursor offset from the front of the line")
diff --git a/bpython/repl.py b/bpython/repl.py
@@ -629,7 +629,7 @@ def set_docstring(self):
                     self.docstring = None
 
     def complete(self, tab=False):
-        """Construct a full list of possible completions and construct and
+        """Construct a full list of possible completions and
         display them in a window. Also check if there's an available argspec
         (via the inspect module) and bang that on top of the completions too.
         The return value is whether the list_win is visible or not.
