Repository navigation
Первый Pull Request - #1
Open
boris-sulyagin wants to merge 2 commits into
Open
boris-sulyagin wants to merge 2 commits into
boris-sulyagin wants to merge 2 commits into
Conversation
vlad-zotov
reviewed
Oct 9, 2023
| Сalculator сalculator = new Сalculator(); | ||
| Scanner scanner = new Scanner(System.in); | ||
|
|
||
| void count() { |
There was a problem hiding this comment.
Привет! В java обычно стоит уделять внимание модификаторам доступа. В маленьких проектах не критично, но в больших играет роль в архитектурных решениях.
There was a problem hiding this comment.
"Завершить" правильнее будет вынести в константы, так ты сможешь безболезненно расширять список стоп слов для своей программы
There was a problem hiding this comment.
для удобства чтения кода советую разносить длинные цепочки .concat на отдельные строки
Программа правильно склоняет слово рубль при значениях от 11 до 14
vlad-zotov
reviewed
Oct 10, 2023
| double inPrice = Math.floor(price) % 100; | ||
|
|
||
| if ((inPrice >= 11) && (inPrice < 15)) { | ||
| switch ((int) inPrice) { |
There was a problem hiding this comment.
здесь тебе не нужен switch у тебя для всех этих значений должно возвращаться слово "рублей". Нужно просто сделать r = "рублей". И ещё начиная с 13 джавы switch начал понимать такой синтаксис
switch(value) {
case: 1,2,3,4 -> {
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Подготовил консольное приложение