Repository navigation
feat(explore): find quoted prose in indexed source - #392
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (10)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 SummarySummary by CodeRabbit
Walkthrough
ChangesQuoted-prose search
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The quoted-prose search is ready for normal validation; complete the planned end-to-end comparison before merging. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to Quoted searches can now bring additional source files into answers, sometimes as whole files within existing output limits. Project-path checks and configuration exclusions remain in place. No introduced security vulnerability was established, but consistency between matching and rendering during concurrent file changes is not guaranteed. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Quoted UI sentences often have no literal-index entry, so an explore query such as
Where is "Shipping updates are temporarily unavailable"?could return unrelated code or no source. Explore now scans indexed script and template source for quoted phrases of at least three words, ignoring case and punctuation. It returns the enclosing callable or matching template lines within existing output limits. No re-index is required.The scan admits templates with no graph nodes, preserves numeric words such as
protocol/2, and excludes configuration values before collecting matches. It reuses the native contained-source reader. Bounds are four phrases of at most 300 characters, 16 matches, 1 MiB per file and 64 MiB total, with a 300 ms budget checked between files. Ordinary symbol queries and two-word quotes skip the scan.Validation: three public source-retrieval regressions fail on the base and pass here; a normalization mutation fails the numeric regression. All 83 focused tests and the full suite pass (7,377 passed, 39 skipped). Four Vite/Flask controls are byte-identical; the original failure in a private downstream project returns the sentence in three query variants, with every answer below 25,000 characters. The selected end-to-end correctness check passed: one Astra xhigh candidate run located the source and correctly explained the display condition, including its alternate-message exception. The parent checked the cited source. The run used three explore calls and two MCP resource-listing calls, made no command-execution calls, and both owned processes exited cleanly. Shell tools were disabled for this MCP-only check, so it does not measure unforced Read/Grep fallback. This single case establishes neither speed nor weaker-model sufficiency; the failed Sonnet attempt is retained separately. After static review, only test fixtures and assertions changed; no further review round ran.
README rows checked: quoted prose source, local callee bodies, requested tests and missing-name notes. README, MCP reference, server instructions and CHANGELOG describe the resulting behavior and limits. No quoted benchmark number changed.