Fix 1 << 16 size array impl: only possible on bigger than 16-bit (0.3 branch) - #84
Merged
Merged
Conversation
bluss
changed the title
What the test was doing was simply UB and we can't expect rustc to make sense of it. The test was failing with optimizations on, yet a closer look says arrayvec is still working as it should. So remove the broken test.
Owner
Author
|
Picked the failing test fix from master. The test is UB, so it was broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes, in the 0.3 branch, bug #83
And two 0.3 branch fixes picked from master