Name AMD modules to support loading multiple ones from minified bundle#66
Closed
fredrikekelund wants to merge 1 commit into
Closed
Name AMD modules to support loading multiple ones from minified bundle#66fredrikekelund wants to merge 1 commit into
fredrikekelund wants to merge 1 commit into
Conversation
When the entire bundle (load-image.all.min.js) is loaded, require.js has no concept of which of the bundled modules is which unless we explicitly provide names for them. The developer still needs to tell require.js that this file contains all of the referenced modules though, so I added a note about that in the README.
Owner
|
The minified file is just provided as a convenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the entire minified bundle (
load-image.all.min.js) is loaded with require.js, require.js has no concept of which of the modules in that file is which unless we explicitly provide names for them. The developer still needs to tell require.js that this file contains all of the referenced modules though, so I added a note about that in the README.