James Bierly Javascript Challenge - #560
Open
jbierly1 wants to merge 7 commits into
Open
Conversation
Great
Requested Improvements
Rating: {1-3} =>
|
Author
|
ok, I reworded 1 and added to 3 on the Answers.md. arrays-objects #133 I'd
fixed in Repl.it but forgot to copy back into VSCode. Should work now.
142 and 127 are fixed now. Cynde can graduate I guess. I spelled out
answer in Functions. In terms of the indentation, I assume we'll talk
about that on Saturday. I was using Prettier for this code, so you
probably know how to adjust it properly. In classes anw was just my name
for the variable I was going to return... I went ahead and rewrote it so
it's "answer" as well. Thanks for the detailed feedback, talk to you soon!
…On Tue, Aug 28, 2018 at 11:29 AM Julian Jay Kohlman < ***@***.***> wrote:
Great
- Overall: You did well James, couple areas you can improve your
overall code, but you've definitely shown you understand the material. Keep
it up, and let me know if you have questions about your feedback.
- awesome use of the regex on line # 151
- Functions good explanation on the nestedFunction() question.
Requested Improvements
- Answers.md Re-read .forEach()
<https://devdocs.io/javascript/global_objects/array/foreach>
- Answers.md: on the whole your answers are good, but I'd look over
those topics for question #1
<#1>,
and #3
<#3>,
just to solidify your knowledge.
- arrays-objects: line #133
<#133>
check your syntax when using Array.sort() it's causing a TypeError.
- line # 142 & 127 why are you starting i at 1? What about poor Cynde
at graduates[0]?
- Functions: I'd use a more descriptive variable name for answ maybe
result or answer.
- There's some uneven indentation in some of the files. If you're
using a code-formatter you can tweak the indentation settings to fix that.
- Classes: On lines #8
<#8>,
#13
<#13>
what is the anw variable representing in your CuboidMaker object?
Rating: {1-3} =>
- (2.5) can easily be a 3 with fix to arrays-objects.js
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#560 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ac3L5PWAWUTjvTs1lRqMfebk-9tXTxoKks5uVWHugaJpZM4WMcc1>
.
|
…nstituteoftechnology#133 I'd fixed in Repl.it but forgot to copy back into VSCode. Should work now. 142 and 127 are fixed now. Cynde can graduate I guess. I spelled out answer in Functions. In terms of the indentation, I assume we'll talk about that on Saturday. I was using Prettier for this code, so you probably know how to adjust it properly. In classes anw was just my name for the variable I was going to return... I went ahead and rewrote it so it's answer as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@juliankohlman