Brandon White - #423
Open
bwhite06 wants to merge 7 commits into
Open
Conversation
crash crash.... working on ojects
|
Great work finishing your classes.js assignment! |
47analogy
reviewed
Dec 23, 2018
|
|
||
| for(let i =0; i<graduates.length;i++){ | ||
| universities.push(graduates[i].university); | ||
| } |
There was a problem hiding this comment.
can use sort method (on line 83) to sort the array alphabetically
47analogy
reviewed
Dec 23, 2018
| console.log(lowerCase); | ||
| for (let i = 0; i < zooAnimals.length; i++) { | ||
| lowerCase.push(zooAnimals[i].animal_name); | ||
| } |
There was a problem hiding this comment.
instead of using a for loop and pushing to the array, you can save a few lines of code because map returns a new array:
lowercase = zooAnimals.map(x => x.animal_name.toLowerCase());
console.log(lowercase);
|
Brandon, nice work on the Sprint Challenge! MVP is complete:
You have a decent amount of commits, but the messages could be a bit more explicit. For example one of them was "fixed problem". Ideally, you'll want to say what the code change fixed / what was wrong. Keep up the good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.