1st Sprint Challenge - #104
Closed
rusticlion wants to merge 6 commits into
Closed
Conversation
boomer1204
reviewed
Jan 12, 2018
| @@ -1,2 +1,44 @@ | |||
| # Your responses to the short answer questions should be laid out here using Mark Down. | |||
| ### For help with markdown syntax [Go here](https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet) | |||
|
|
|||
There was a problem hiding this comment.
These are great descriptions. It definitely appears that you have a good understanding of the concepts.
boomer1204
reviewed
Jan 12, 2018
|
|
||
| const map = (elements, cb) => { | ||
| // Produces a new array of values by mapping each value in list through a transformation function (iteratee). | ||
| // Return the new array. |
There was a problem hiding this comment.
This is a great solution. If you come back to this try and solve this using the each function you created above (just a little extra credit/thinking)
boomer1204
reviewed
Jan 12, 2018
| const flatten = elements => { | ||
| // Flattens a nested array (the nesting can be to any depth). | ||
| // Example: flatten([1, [2], [3, [[4]]]]); => [1, 2, 3, 4]; | ||
| return elements.reduce((flatArray, toFlatten) => { |
There was a problem hiding this comment.
Great use of Array in this code base
boomer1204
approved these changes
Jan 12, 2018
boomer1204
left a comment
boomer1204
left a comment
There was a problem hiding this comment.
Very good commit. The checkMatchingLeaves is not passing but that is a very difficult challenge. Rest of the code looks good. Keep it up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished all but cacheFunction, checkMatchingLeaves, and recursive reverseString. Also, I made my final push at 10:55, I just forgot to submit the pull until just now.