JavaScript-IV-James-Blazer - #544
Open
jblazer1 wants to merge 2 commits into
Open
Conversation
Xarfo
approved these changes
Nov 30, 2018
Xarfo
left a comment
Xarfo
left a comment
There was a problem hiding this comment.
Jim - Good job on the completion of last evening's project. Keep up the good work and excel in today's sprint.
What Looks Great
- MVP complete! Nice work
- Code is well formatted and easy to read
What Could Be Improved
- There are tons of stretch goals to work on when you have time! It's great practice to come back to this project and work on it to keep up your full-stack skills!
- Please commit descriptively more often.
| } | ||
| } // Person | ||
|
|
||
| class Instructor extends Person { |
| gender: "male", | ||
| gradClassName: "CS1", | ||
| favInstructor: "Fred" | ||
| }); |
There was a problem hiding this comment.
Object creation using the new keyword looks good.
Xarfo
reviewed
Nov 30, 2018
| favInstructor: "Tom" | ||
| }); | ||
|
|
||
| const paulie = new ProjectManagers({ |
Xarfo
reviewed
Nov 30, 2018
| sprintCallenge(subject) { | ||
| console.log(`${this.name} has begun sprint challenge on ${subject}`); | ||
| } | ||
| } // Student |
There was a problem hiding this comment.
Class inheritance is extended correctly and implemented.
constructor(stuAtrr) {
super(stuAtrr);
this.previousBackground = stuAtrr.previousBackground;
this.className = stuAtrr.className;
this.favSubjects = stuAtrr.favSubjects;
}
listsSubjects() {
for(let i = 0; i < this.favSubjects.length; i++)
console.log(`My favorite subjects are ${this.favSubjects[i]}`);
}
PRAssignment(subject) {
console.log(`${this.name} has submitted a PR for ${subject}`);
}
sprintCallenge(subject) {
console.log(`${this.name} has begun sprint challenge on ${subject}`);
}
} // Student```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.