Conversation
…he student doesn't pass
…he student doesn't pass
szincone
reviewed
Oct 22, 2018
| return `${student.name} receives a perfect score on ${subject}`; | ||
| } | ||
| gradeAssignment(student) { | ||
| let points = 20 - Math.floor(Math.random() * 30); |
There was a problem hiding this comment.
Good use of Math.random and Math.floor to generate a random score.
| if (this.grade >= 70) { | ||
| return `Congrats ${this.name}! You have just graduated Lambda School!`; | ||
| } | ||
| while (this.grade < 70) { |
There was a problem hiding this comment.
Fun use of a while loop to do graduating and re-invoking the gradeAssignment function if its too low.
| return `${this.name} announces to ${channel}, @channel standy times!`; | ||
| } | ||
| debugsCode(student, subject) { | ||
| return `${this.name} debugs ${student.name}'s code on ${subject}`; |
There was a problem hiding this comment.
Good job using this correctly to access the PM's name.
| } | ||
|
|
||
| listsSubjects() { | ||
| return `${this.favSubjects[0]},${this.favSubjects[1]},${ |
There was a problem hiding this comment.
Could possibly have this method be a forEach loop and just return each subject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ashwins93