Skip to content

Daren Larson - #415

Open
darenlarson wants to merge 7 commits into
bloominstituteoftechnology:masterfrom
darenlarson:master
Open

Daren Larson#415
darenlarson wants to merge 7 commits into
bloominstituteoftechnology:masterfrom
darenlarson:master

Conversation

@darenlarson

Copy link
Copy Markdown

No description provided.

@ashwins93 ashwins93 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Your use of comments on the code is perfect. It makes the code readable and meaningful. Your future self will be happy you did this. Keep pushing yourself for the stretch goals. Good git commits.

this.grade = studentAttributes.grade;
}
listsSubjects() {
for (let i = 0; i < this.favSubjects.length; i++) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good place to use forEach

console.log(`Sorry, ${this.name}. You have failed and need to roll back to the next cohort. :( ...maybe you should ask ${PM.name} to change your grade ;)`);
PM.changeGrade(this);
console.log(`${PM.name}: I have updated your grade to: ${this.grade}`);
this.graduate(PM);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the use of recursion here. Very clean.

});

// Project Manager Test
const trevor = new ProjectManager ({

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trevorfehrman This is your doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants