Lajawanti-Dhake - #366
Open
innovationcode wants to merge 2 commits into
Open
Conversation
Velsu
reviewed
Jul 3, 2019
Velsu
left a comment
Velsu
left a comment
There was a problem hiding this comment.
Lajawanti great job on the assingment. You completed the MVP. You successfully refactored prototypes and completed the lambda class exercise.
Your code is clean and concise.
Your git workflow is somewhat fluid considering length of the exercise. The only improvement i could suggest is more detailed commit messages that will better describe Your current workflow.
You displayed mastery on the subject and did really solid job, well done 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mmargo10 "Javascript-IV"