Brian Williams -- Javascript IV - #352
Open
bkwillia052 wants to merge 4 commits into
Open
Conversation
Velsu
reviewed
Feb 10, 2019
| this.previousBackground = props.previousBackground; | ||
| this.className = props.className; | ||
| this.favSubjects = props.favSubjects; | ||
| /* Below I meant set up a conditional that would prevent the grade prop from |
There was a problem hiding this comment.
It is not working with gradeBlaster() because You are not using constructor that time but instead rewriting the property to whatever gradeBlaster() returns. So You can either directly set the conditional on gradeBlaster() or try to play around with setters and getters for an object to configure what the grade can be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kamry-bowman