Brandon Benefield: JavaScript-III - #24
Closed
bbenefield89 wants to merge 2 commits into
Closed
Conversation
ghost
reviewed
Apr 19, 2018
| this.hp = myObj.hp | ||
| this.name = myObj.name | ||
| } | ||
| CharacterStats.prototype = Object.create(GameObject.prototype); |
There was a problem hiding this comment.
Perfect use of the call and Object create combo. 💯
ghost
reviewed
Apr 19, 2018
|
|
||
| function Humanoid(myObj) { | ||
| CharacterStats.call(this, myObj) | ||
| this.faction = myObj.faction |
There was a problem hiding this comment.
this really can getcha, if you need semi-colons feel free to ask and I will lend you some. Worst case you find an error down the road that probably even tells you where an assignment went wrong...
// This is/should be valid javascript
let a, b, c;
a = b = c = 1;
// ===
a = b
c = 1;There was a problem hiding this comment.
While this behavior does right itself when typed in the browser console. I wouldn't rely on it myself.
juliankohlman
referenced
this pull request
Aug 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.