Skip to content

Complete Aquila Strother#167

Closed
astro11 wants to merge 3 commits intobloominstituteoftechnology:masterfrom
astro11:master
Closed

Complete Aquila Strother#167
astro11 wants to merge 3 commits intobloominstituteoftechnology:masterfrom
astro11:master

Conversation

@astro11
Copy link
Copy Markdown

@astro11 astro11 commented Feb 23, 2018

No description provided.

@astro11 astro11 changed the title WIP Aquila Strother Complete Aquila Strother Feb 26, 2018
Comment thread src/class.js
// Return true if the potential password matches the `password` property. Otherwise return false.

class User {
constructor(options) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use object destructuring here:

  constructor({ email, password }) {
    this.email = email;
    this.password = password;
  }

Comment thread src/class.js
}
}

const newUser = new User({
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove and 'test' code before your final git push!

@frankfaustino
Copy link
Copy Markdown

Hi Aquila! Solid work as usual.

  • Tests pass ✔️
  • Code is consistent with JS idioms and style ✔️
  • Solid grasp of Classes, Prototype inheritance, this, and recursion ✔️

Keep up the fantastic work! Please close this PR when you get a chance. Thanks!

@astro11 astro11 closed this Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants