Skip to content

Asa Shalom: MVP - #440

Open
AsaOfDiamonds wants to merge 5 commits into
bloominstituteoftechnology:masterfrom
AsaOfDiamonds:master
Open

Asa Shalom: MVP#440
AsaOfDiamonds wants to merge 5 commits into
bloominstituteoftechnology:masterfrom
AsaOfDiamonds:master

Conversation

@AsaOfDiamonds

Copy link
Copy Markdown

No description provided.

@AsaOfDiamonds AsaOfDiamonds changed the title Asa Shalom: WIP Asa Shalom: MVP Oct 15, 2018

@szincone szincone left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Very strong MVP. Code is clean and well-formatted throughout.

Comment thread assignments/arrays.js
// ==== Challenge 1 ====
// The dealer can't recall the information for a car with an id of 33 on his lot. Help the dealer find out which car has an id of 33 by logging the car's year, make, and model in the console log provided to you below:
console.log(`Car 33 is a *car year goes here* *car make goes here* *car model goes here*` );
inventory.carInfo = function (info) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Good job on implementing a method for this challenge!

Comment thread assignments/arrays.js
inventory.makeModel = function(info) {
for (let i = 0; i < inventory.length; i++) {
if (i === info -1) {
console.log(`${inventory[i].car_make} ${inventory[i].car_model}`);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Good use of template literal syntax (back-ticks) throughout

Comment thread assignments/objects.js
// Antonietta loves math, give her the ability to multiply two numbers together and return the product. Use the console.log provided as a hint.
//console.log(antonietta.multiplyNums(3,4));

console.log(intern5.multiplyNums(3,4))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Good job on invoking the methods (line 90 and 76)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants