Ashwin Sundararajan - Completed objectives + stretch - #164
Open
ashwins93 wants to merge 7 commits into
Open
Conversation
ashwins93
changed the title
Nate152
reviewed
Jun 26, 2018
| for (let i = 0; i < inventory.length; i++) { | ||
| if (inventory[i].id === 33) { | ||
| let car = inventory[i]; | ||
| console.log(`Car 33 is a ${car.car_year} ${car.car_make} ${car.car_model}`); |
There was a problem hiding this comment.
I don't think we needed to loop here. Could have made it even simpler by just saying:
console.log('Car 33 is a ${inventory[32].car_year} ${inventory[32].car_make} ${inventory[32].car_model')
I do like that you used the template literals though despite that they were not covered in the lecture
|
Overall great job as usual. I made a comment on the one very minor thing. The way that you did it is by no means wrong, but obviously its less efficient than simply console logging it. Finally a critique 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CS 12 - JavaScript I