Skip to content

Improve README instructions and change from hard tabs to two spaces. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SunJieMing merged 1 commit into from
Aug 7, 2017
Merged

Improve README instructions and change from hard tabs to two spaces. #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,26 @@
# Basic JavaScript Mini
# Basic JavaScript Mini
Copy link
Copy Markdown
Contributor

@SunJieMing SunJieMing Aug 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to X


Topics:
* GitHub/Git
* Flow: fork -> clone -> (add/commit/push) -> pull request
* arrow functions `=>`
* `const`
* `let`
* String templates
* GitHub/Git
* Flow: fork -> clone -> (add/commit/push) -> pull request
* arrow functions `=>`
* `const`
* `let`
* String templates

## Project Description

### Initialize Project
* Change the JavaScript in the script file to use the new ES6 syntax.
* Change the JavaScript in the script file to use the new ES6 syntax.
* Change the functions to be arrow functions.
* Change the variables to `const` and `let`.

### Steps for submitting a pull request
### Steps for submitting a pull request
* Change your current working directory to your project: `cd /path/to/project`,
where `/path/to/project` is the filesystem path to your project directory.
* Step 1: Add all of your changes: `git add --all`
* Step 2: Commit your changes: `git commit -m "Changed code to ES6"`
* Step 3: Push your changes: `git push origin master`
* Step 3: Push your changes: `git push origin master`
* Step 4: On GitHub submit a pull request back to the main repo.

We do code reviews based off of this pull request process.

16 changes: 8 additions & 8 deletions script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
var logger = function() {
var message = 'hi';
console.log(message);
var message = 'hi';
console.log(message);
};

var looper = function() {
var message = 'I love JS!';
for (var i = 0; i < 10; i++) {
console.log(message);
}
var message = 'I love JS!';
for (var i = 0; i < 10; i++) {
console.log(message);
}
};

var greet = function(name) {
var greeting = 'Hello ' + name + '!';
console.log(greeting);
var greeting = 'Hello ' + name + '!';
console.log(greeting);
};

var yourName = 'put your name in here';
Expand Down