Skip to content

Commit cec4a52

Browse files
author
SlavaRa
committed
Fixes redundant 'Object.ToString()' call for value type
1 parent 6669655 commit cec4a52

19 files changed

Lines changed: 34 additions & 34 deletions

File tree

‎External/Plugins/ASCompletion/Completion/ASGenerator.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3053,7 +3053,7 @@ private static string GuessVarName(string name, string type)
30533053
name = name.TrimStart(new char[] { '_' });
30543054
if (name.Length > 3 && name.StartsWith("get") && (name[3].ToString() == char.ToUpper(name[3]).ToString()))
30553055
{
3056-
name = char.ToLower(name[3]).ToString() + name.Substring(4);
3056+
name = char.ToLower(name[3]) + name.Substring(4);
30573057
}
30583058

30593059
if (name.Length > 1)

‎External/Plugins/ASCompletion/Model/ASFileParser.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ public static TypeDefinitionKind ParseTypedCallback(string comment, MemberModel
193193
private static string getRandomStringRepl()
194194
{
195195
random.NextDouble();
196-
return "StringRepl" + random.Next(0xFFFFFFF).ToString();
196+
return "StringRepl" + random.Next(0xFFFFFFF);
197197
}
198198

199199
/// <summary>

‎External/Plugins/ASCompletion/PluginUI.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ internal void UpdateView(FileModel aFile)
533533
}
534534
foreach (MemberModel member in aFile.Members)
535535
{
536-
sb.Append(member.Flags.ToString()).Append(member.ToString());
536+
sb.Append(member.Flags).Append(member);
537537
lines.Add(member.LineFrom);
538538
names.Add(member.Name);
539539
}
@@ -542,7 +542,7 @@ internal void UpdateView(FileModel aFile)
542542
if (string.IsNullOrEmpty(aClass.ExtendsType))
543543
aClass.ResolveExtends();
544544

545-
sb.Append(aClass.Flags.ToString()).Append(aClass.FullName);
545+
sb.Append(aClass.Flags).Append(aClass.FullName);
546546
sb.Append(aClass.ExtendsType);
547547
if (aClass.Implements != null)
548548
foreach (string implements in aClass.Implements)
@@ -551,7 +551,7 @@ internal void UpdateView(FileModel aFile)
551551
names.Add(aClass.Name);
552552
foreach (MemberModel member in aClass.Members)
553553
{
554-
sb.Append(member.Flags.ToString()).Append(member.ToString());
554+
sb.Append(member.Flags).Append(member);
555555
lines.Add(member.LineFrom);
556556
names.Add(member.Name);
557557
}

‎External/Plugins/AirProperties/Forms/AirWizard.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1065,11 +1065,11 @@ private void UpdateIcon(string fileName, ref TextBox fileNameTextBox, Point dime
10651065
{
10661066
if (_pluginMain.Settings.UseUniformFilenames)
10671067
{
1068-
destinationFileName = filePrefix + dimensions.X.ToString() + Path.GetExtension(fileName);
1068+
destinationFileName = filePrefix + dimensions.X + Path.GetExtension(fileName);
10691069
}
10701070
else if (_pluginMain.Settings.RenameIconsWithSize)
10711071
{
1072-
destinationFileName = Path.GetFileNameWithoutExtension(fileName) + dimensions.X.ToString() + Path.GetExtension(fileName);
1072+
destinationFileName = Path.GetFileNameWithoutExtension(fileName) + dimensions.X + Path.GetExtension(fileName);
10731073
}
10741074
else destinationFileName = Path.GetFileName(fileName);
10751075
if (!Directory.Exists(destinationPath))
@@ -1089,7 +1089,7 @@ private void UpdateIcon(string fileName, ref TextBox fileNameTextBox, Point dime
10891089
}
10901090
else
10911091
{
1092-
MessageBox.Show(String.Format(TextHelper.GetString("Alert.Message.InvalidIconDimensions"), dimensions.X.ToString(), dimensions.Y.ToString()), TextHelper.GetString("Alert.Title.InvalidIconDimensions"), MessageBoxButtons.OK, MessageBoxIcon.Exclamation);
1092+
MessageBox.Show(String.Format(TextHelper.GetString("Alert.Message.InvalidIconDimensions"), dimensions.X, dimensions.Y), TextHelper.GetString("Alert.Title.InvalidIconDimensions"), MessageBoxButtons.OK, MessageBoxIcon.Exclamation);
10931093
}
10941094
}
10951095

‎External/Plugins/CodeFormatter/Handlers/ASPrettyPrinter.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4735,7 +4735,7 @@ public EqualContext(EqualContext parent, int index)
47354735
mParent=parent;
47364736
if (parent!=null)
47374737
{
4738-
mPathCode=parent.mPathCode+index.ToString();
4738+
mPathCode = parent.mPathCode + index;
47394739
}
47404740
else
47414741
{

‎External/Plugins/CodeRefactor/Commands/Rename.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ private void ReportResults()
347347
reportableLines[lineNumber] = new List<string>();
348348
}
349349
// the data we store matches the TraceManager.Add's formatting. We insert the {0} at the end so that we can insert the final line state later
350-
reportableLines[lineNumber].Add(entry.Key + ":" + match.Line.ToString() + ": chars " + column + "-" + (column + newNameLength) + " : {0}");
350+
reportableLines[lineNumber].Add(entry.Key + ":" + match.Line + ": chars " + column + "-" + (column + newNameLength) + " : {0}");
351351
}
352352
// report all the lines
353353
foreach (KeyValuePair<int, List<String>> lineSetsToReport in reportableLines)

‎External/Plugins/FileExplorer/PluginUI.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ private void UpdateUI(string path, DirectoryInfo directory, FileSystemInfo[] inf
453453
item = new ListViewItem(file.Name, ExtractIconIfNecessary(file.FullName));
454454
item.Tag = file.FullName;
455455
if (file.Length / 1024 < 1) item.SubItems.Add("1 " + kbs);
456-
else item.SubItems.Add((file.Length / 1024).ToString() + " " + kbs);
456+
else item.SubItems.Add((file.Length / 1024) + " " + kbs);
457457
item.SubItems.Add(file.Extension.ToUpper().Replace(".", ""));
458458
item.SubItems.Add(file.LastWriteTime.ToString());
459459
this.fileView.Items.Add(item);

‎External/Plugins/FlashDebugger/Controls/DataTree/ValueNode.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,11 @@ public override string Value
6969
{
7070
if (number < 0 && number >= Int32.MinValue)
7171
{
72-
return number.ToString() + " [0x" + ((Int32)number).ToString("x") + "]";
72+
return number + " [0x" + ((Int32)number).ToString("x") + "]";
7373
}
7474
else if (number < 0 || number > 9)
7575
{
76-
return number.ToString() + " [0x" + ((Int64)number).ToString("x") + "]";
76+
return number + " [0x" + ((Int64)number).ToString("x") + "]";
7777
}
7878
}
7979
else return number.ToString();

‎External/Plugins/FlashDebugger/Helpers/MenusHelper.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ public void UpdateMenuState(object sender, DebuggerState state)
289289
// Notify plugins of main states when state changes...
290290
if (hasChanged && (state == DebuggerState.Running || state == DebuggerState.Stopped))
291291
{
292-
DataEvent de = new DataEvent(EventType.Command, "FlashDebugger." + state.ToString(), null);
292+
DataEvent de = new DataEvent(EventType.Command, "FlashDebugger." + state, null);
293293
EventManager.DispatchEvent(this, de);
294294
}
295295
PluginBase.MainForm.RefreshUI();

‎External/Plugins/ProjectManager/Controls/TreeView/OtherNodes.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ public override void Refresh(bool recursive)
248248
string absolute = globalClasspath;
249249
if (!Path.IsPathRooted(absolute))
250250
absolute = project.GetAbsolutePath(globalClasspath);
251-
if (absolute.StartsWith(project.Directory + Path.DirectorySeparatorChar.ToString()))
251+
if (absolute.StartsWith(project.Directory + Path.DirectorySeparatorChar))
252252
continue;
253253

254254
cpNode = ReuseNode(absolute, nodesToDie) as ProjectClasspathNode ?? new ClasspathNode(project, absolute, globalClasspath);

0 commit comments

Comments
 (0)