Repository navigation
Conversation
Contributor
|
To be honest, I don't see the point of this. We are sending the requests over a HTTPS connection. So, if someone is able to observe the URL he is also able to observe the request body. In that case, all it takes to get the unlimited api key is a single job creation request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For security reasons we do not want to send an api key as part of the url for any requests to Zencoder. On enquiring about this with them we were informed that you can create a read only api key - which can only be used for things like progress requests, and not for creating jobs. This means that even if someone gets hold of it they are unable to abuse our account, merely to try and monitor what we are doing. If this read only key is not set in the constructor then the code behaves as before, using the main api key.