Repository navigation
Added handling of request timeouts - #25
Merged
Merged
Conversation
drallgood
added a commit
that referenced
this pull request
Aug 21, 2013
Added handling of request timeouts Thanks to @stormtek
Contributor
|
Looks awesome and is actually a good idea. Thanks! |
Contributor
Author
|
No problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are very close to using this wrapper in our application. However, we noticed that it was hanging sometimes on calls to Zencoder. Because of this we have added timeouts to the httpClient and then handling for when exceptions are thrown. Each call to Zencoder will happen MAX_CONNECTION_ATTEMPTS before failing. Basic real world testing shows that this is helping.