Add maker and taker attributes to fee model#42
Merged
Conversation
nvcruzhe
approved these changes
Jun 8, 2018
nvcruzhe
reviewed
Jun 8, 2018
nvcruzhe
left a comment
nvcruzhe
left a comment
Contributor
There was a problem hiding this comment.
Just need to update the tests
Signed-off-by: Carlos Omana <[email protected]>
carlosguerreroo
force-pushed
the
co_add_maker_and_taker
branch
from
d046fdc to
c35b3ac
Compare
vogelito
reviewed
Jun 9, 2018
vogelito
left a comment
vogelito
left a comment
Member
There was a problem hiding this comment.
Please annotate:
getFeeDecimal
setFeeDecimal
getFeePercent
setFeePercent
as @deprecated
…ated Signed-off-by: Carlos Omana <[email protected]>
Contributor
Author
|
ty, @vogelito done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carlos Omana [email protected]