Fix PasswordKey/BrainKey key generation.#78
Merged
xeroc merged 1 commit intobitshares:developfrom Apr 16, 2018
Merged
Conversation
We can't use base Graphene objects as is, because they
create keys with wrong prefixes ("GPH"). Maybe this should
be fixed the other way around.
This also adds `get_blind_private` to BrainKey class. As the
name suggests, that is the correct method to generate private keys
for blind accounts.
Codecov Report
@@ Coverage Diff @@
## develop #78 +/- ##
===========================================
- Coverage 68.53% 68.32% -0.22%
===========================================
Files 51 51
Lines 3966 3987 +21
===========================================
+ Hits 2718 2724 +6
- Misses 1248 1263 +15
Continue to review full report at Codecov.
|
Member
|
Nice catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't use base Graphene objects as is, because they create keys with wrong prefixes ("GPH").
Maybe this should be fixed the other way around.
This also adds
get_blind_privateto BrainKey class. As the name suggests, that is the correct method to generate private keys for blind accounts.