Skip to content

Pass blockchain_instance in Asset methods#224

Merged
xeroc merged 2 commits intobitshares:developfrom
bitphage:tip-asset-fixes
Apr 8, 2019
Merged

Pass blockchain_instance in Asset methods#224
xeroc merged 2 commits intobitshares:developfrom
bitphage:tip-asset-fixes

Conversation

@bitphage
Copy link
Copy Markdown
Contributor

No description provided.

@bitphage bitphage changed the title Tip asset fixes Pass blockchain_instance in Asset methods Mar 29, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 29, 2019

Codecov Report

Merging #224 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #224   +/-   ##
========================================
  Coverage    36.26%   36.26%           
========================================
  Files           34       34           
  Lines         2137     2137           
  Branches       489      489           
========================================
  Hits           775      775           
  Misses        1236     1236           
  Partials       126      126
Impacted Files Coverage Δ
bitshares/asset.py 22.16% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26719f7...5ad6701. Read the comment docs.

@xeroc
Copy link
Copy Markdown
Member

xeroc commented Apr 8, 2019

Nice catch

@xeroc xeroc merged commit 7a37be8 into bitshares:develop Apr 8, 2019
@bitphage bitphage deleted the tip-asset-fixes branch April 8, 2019 12:49
xeroc added a commit that referenced this pull request Apr 12, 2019
Release 0.3.2

8a3b595 (HEAD -> master) Merge branch 'release/0.3.2'
73323fb (release/0.3.2) version bump
f7b18ac (origin/develop, develop) Implement getOperationName
56a3d17 Modify instances according to new pygraphene to allow setting config before instanciation (#188)
d2b9c42 Add the unknown chainid to the error message
cb4772a Introduce exception for unknown chainid (#221)
2595586 Make #229 not raise a KeyError exception
7a37be8 Merge pull request #224 from bitfag/tip-asset-fixes
d22cfc5 Merge pull request #228 from bitshares/pyup-scheduled-update-2019-04-01
ba6b0bb Updates to docs and Authors
3f34527 version bump
855fb83 (origin/pyup-scheduled-update-2019-04-01) Update pre-commit from 1.14.4 to 1.15.0
1e3bb92 Update pytest-mock from 1.10.2 to 1.10.3
192e409 Update pytest from 4.3.1 to 4.4.0
9bad2f9 Update graphenelib from 1.1.12 to 1.1.14
5ad6701 Pass blockchain_instance in Asset methods
081859f Fix typo in finalizeOp call
26719f7 Merge pull request #220 from bitfag/219-balance-claim-operation
54d712d Add balance_claim operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants