This repository was archived by the owner on Apr 9, 2021. It is now read-only.
Python 2 and 3 compatibility - #28
Merged
Merged
Conversation
jsocol
commented
Nov 25, 2013
jsocol
commented
Contributor
- Drop PyCURL, since it's not Py3k compatible.
- Drop bitly_http module, just inline urllib(2) code.
- Steal *_types lists from six.
- Update isinstance calls.
- Update excepts.
- Decode response body as utf-8.
- Drop simplejson import, just use json
- Should be compatible with >=2.6.
- Drop PyCURL, since it's not Py3k compatible. - Drop bitly_http module, just inline urllib(2) code. - Steal *_types lists from six. - Update isinstance calls. - Update excepts. - Decode response body as utf-8.
Contributor
Author
|
@bitly/appdev RFR |
Contributor
Contributor
Author
There was a problem hiding this comment.
Typically this stays as the original author or maintainer and something like a CONTRIBUTORS file would have people who come later. I'm not too worried about it, unless Jehiah would rather have his bitly email there.
davemarchevsky
added a commit
that referenced
this pull request
Dec 18, 2013
Python 2 and 3 compatibility
deletedcu
added a commit
to deletedcu/bitly-api-python
that referenced
this pull request
May 17, 2019
Python 2 and 3 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.