Username/AccessToken provided via Environment variables - #13
Conversation
There was a problem hiding this comment.
when using an OAuth access token, this bitly_username is completely ignored. The tests pass for me w/o that, so i think if you drop that block of code we'll be good to go.
There was a problem hiding this comment.
Good spot - have removed, also tidied some pep8 points.
|
awesome. changes look good. before merging, we prefer to squash changes down to a single commit. Would you mind doing that here? |
|
You're welcome to try on my behalf, this is beyond my git-fu. I tried this https://github.com/ginatrapani/todo.txt-touch/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit and now I have HEAD, develop and two other branches, all in broken states. You're welcome to take my changes and merge them under your own user if that's easier. |
|
sorry, yeah, squashing is annoying sometimes. The workflow I normally use to squash is Then after a successful squash, it obviously requires a force push up to github because history has changed. If you want to try again after restting hard to your remote ( |
…s now use get_connection to fetch user credentials from environment variables updated doc to include notes on running the tests updated doc to include notes on running the tests removed unnecessary username pep8 pedantry
|
Ok, I tried: It looks like it works, please confirm? |
Username/AccessToken provided via Environment variables
|
that did it. thanks for the contribution! |
Username/AccessToken provided via Environment variables
Username and AccessToken are imported using environment variables. If they're missing then a useful error is raised. README updated to explain how to set this up, doc added in test_bitly_api.py to explain how to run the test.
One test changed in test_bitly_api as the 'test1' key is a valid bitly key, maybe this entered the keyspace? I've added a longer random string, I don't know if this keeps the same meaning to the test (this needs validation).