Skip to content

Fix 969 Update SCOP version to 2.08 - #972

Merged
josemduarte merged 1 commit into
biojava:masterfrom
aalhossary:Fix_SCOP_files_lessthan_2.08_not_available_for_download_#969
Sep 27, 2021
Merged

josemduarte merged 1 commit into
biojava:masterfrom
aalhossary:Fix_SCOP_files_lessthan_2.08_not_available_for_download_#969

Conversation

@aalhossary

Copy link
Copy Markdown
Member

All SCOP installation file downloads fail because all files before 2.08
no longer exist (error 404).

1- All downloads are corrected by upgrading the LATEST_VERSION to 2.08.
2- testGetStructureForChainlessDomains is ignored because chainless
domains are present only in SCOP < 1.73

All SCOP installation file downloads fail because all files before 2.08
no longer exist (error 404).

1- All downloads are corrected by upgrading the LATEST_VERSION to 2.08.
2- testGetStructureForChainlessDomains is ignored because chainless
domains are present only in SCOP < 1.73
@aalhossary

Copy link
Copy Markdown
Member Author

Fix for #969

@aalhossary
aalhossary requested a review from sbliven September 25, 2021 02:34
@aalhossary aalhossary changed the title Update Scope version to 2.08 Fix 969 Update SCOP version to 2.08 Sep 25, 2021

@lafita lafita left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@josemduarte josemduarte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing! LGTM

@josemduarte

Copy link
Copy Markdown
Contributor

I'll merge this. I've tested locally and it passes all tests.

I'll also remove an obsolete scop test that was using some old http endpoint that is now gone. I'll push that directly to master.

@josemduarte
josemduarte merged commit 0df1ca4 into biojava:master Sep 27, 2021
@aalhossary
aalhossary deleted the Fix_SCOP_files_lessthan_2.08_not_available_for_download_#969 branch September 28, 2021 06:45
@aalhossary
aalhossary restored the Fix_SCOP_files_lessthan_2.08_not_available_for_download_#969 branch September 30, 2021 02:31
@aalhossary

Copy link
Copy Markdown
Member Author

I restored one previously ignored test.

jnbdz pushed a commit to jnbdz/biojava that referenced this pull request Aug 2, 2026
…n_2.08_not_available_for_download_#969

Fix 969 Update SCOP version to 2.08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants