Repository navigation
CE-Symm Final Stable Version - #401
Merged
Merged
Conversation
Conflicts: biojava-structure/src/main/java/org/biojava/nbio/structure/symmetry/internal/CeSymmIterative.java
It is a generalization of the OpenRefiner for open and closed cases, and uses the jgrapht library, so it is cleaner.
Conflicts: biojava-structure-gui/src/main/java/demo/DemoMultipleMC.java biojava-structure/src/main/java/demo/DemoMultipleMC.java
It was not used because it was decided that only BlockSets have transformations.
This shares some lines of code that were repeated all over.
Conflicts: biojava-structure-gui/src/main/java/org/biojava/nbio/structure/symmetry/gui/SymmetryDisplay.java biojava-structure/src/main/java/org/biojava/nbio/structure/StructureTools.java
andreasprlic
added a commit
that referenced
this pull request
Feb 3, 2016
CE-Symm Final Stable Version
Member
|
great stuff! |
Member
|
Well, as stable as an algorithm can be before the reviewers get a crack at it! |
kamildoleglo
pushed a commit
to kamildoleglo/biojava
that referenced
this pull request
Jul 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans the code for
CE-Symmby removing unused methods, making static functions and improving documentation.New features have been added:
CeSymmResultthat takes care of evaluating the significance of the result, order of symmetry and other properties of symmetry.MultipleAlignment).The algorithm after this PR will be considered a stable version, since the program has been run against the benchmark (1007 domains) and SCOP protein family representatives (5K domains) with the most used parameter combinations and no Exceptions occurred. The benchmark results were also checked for consistency with the true values and the prediction accuracy was within reasonable values for such parameter combinations.