Skip to content

CE-Symm Final Stable Version - #401

Merged
andreasprlic merged 40 commits into
biojava:masterfrom
lafita:cesymm
Feb 3, 2016
Merged

andreasprlic merged 40 commits into
biojava:masterfrom
lafita:cesymm

Conversation

@lafita

@lafita lafita commented Feb 3, 2016

Copy link
Copy Markdown
Member

This PR cleans the code for CE-Symm by removing unused methods, making static functions and improving documentation.

New features have been added:

  • Package internal symmetry results in an object CeSymmResult that takes care of evaluating the significance of the result, order of symmetry and other properties of symmetry.
  • Show phylogenetic trees of the structural alignments (Internal Symmetry and MultipleAlignment).
  • Calculate StructureIdentifiers of the symmetric units (use case for viewer coloring, comparing, etc).

The algorithm after this PR will be considered a stable version, since the program has been run against the benchmark (1007 domains) and SCOP protein family representatives (5K domains) with the most used parameter combinations and no Exceptions occurred. The benchmark results were also checked for consistency with the true values and the prediction accuracy was within reasonable values for such parameter combinations.

lafita added 30 commits January 25, 2016 15:22
Conflicts:
	biojava-structure/src/main/java/org/biojava/nbio/structure/symmetry/internal/CeSymmIterative.java
It is a generalization of the OpenRefiner for open and closed cases, and
uses the jgrapht library, so it is cleaner.
Conflicts:
	biojava-structure-gui/src/main/java/demo/DemoMultipleMC.java
	biojava-structure/src/main/java/demo/DemoMultipleMC.java
It was not used because it was decided that only BlockSets have
transformations.
This shares some lines of code that were repeated all over.
Conflicts:
	biojava-structure-gui/src/main/java/org/biojava/nbio/structure/symmetry/gui/SymmetryDisplay.java
	biojava-structure/src/main/java/org/biojava/nbio/structure/StructureTools.java
@lafita lafita changed the title CE-symm Final Stable Version CE-Symm Final Stable Version Feb 3, 2016
andreasprlic added a commit that referenced this pull request Feb 3, 2016
CE-Symm Final Stable Version
@andreasprlic
andreasprlic merged commit 0d3da32 into biojava:master Feb 3, 2016
@andreasprlic

Copy link
Copy Markdown
Member

great stuff!

@sbliven

sbliven commented Feb 9, 2016

Copy link
Copy Markdown
Member

Well, as stable as an algorithm can be before the reviewers get a crack at it!

@lafita lafita added this to the BioJava 5.0.0 milestone Mar 22, 2018
kamildoleglo pushed a commit to kamildoleglo/biojava that referenced this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants