Repository navigation
Fix313 - ChemCompProvider and ChemComp cache consistency - #314
Conversation
The cache is not reset every time, so the ReducedChemCompProvider can use ChemComp information already cached by the DownloadChemCompProvider.
|
I'd prefer to use |
|
That's a good point, it sounds logical that the At the same time the So it's difficult to say what's the better default. We are going to try and check how the tests do when changing the default. That can give us some more clues of what things can go wrong. |
|
I think that there was no problem before in using the I have tried to set the
In any case we need to document in the |
See explanation of the reasons in #314.
Fix313 - ChemCompProvider and ChemComp cache consistency
See issue #313.
This pull request solves issue 313 by forcing the user to specify which ChemCompProvider is used when parsing a PDB or MMCiff file. The cache is kept and increased while the JVM is running, so ChemComp downloaded and cached by the DownloadChemCompProvider can also be user later by the ReducedChemCompProvider. The cache is never reset in the same JVM.