You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Misspelled spacegroup field in generated CIFs #480
CIF files should contain _symmetry.space_group_name_H-M, but the hyphen is getting converted into an underscore. This may occur for other mmCIF fields containing hyphens as well:
Unit tests are missing this because the SimpleMMcifParser internally converts all hyphens to underscores. We don't test that writing a CIF matches the original CIF, so we don't pick this up.
I've just discovered that the 2 pull requests related to this issue (#482 and #489) were not included into the bugfixes-4.2 branch. Even if the pull request introduced some new things (e.g. annotation tags), essentially they are just fixing this bug. I'll try to cherry-pick them and produce a 4.2.3 release if there's nothing against it.
Activity
sbliven commentedon May 13, 2016
Unit tests are missing this because the SimpleMMcifParser internally converts all hyphens to underscores. We don't test that writing a CIF matches the original CIF, so we don't pick this up.
Fix biojava#480. Correct spelling of _symmetry.space_group_name_H-M i…
Merge pull request #482 from sbliven/fix480
josemduarte commentedon Jun 22, 2016
I've just discovered that the 2 pull requests related to this issue (#482 and #489) were not included into the
bugfixes-4.2branch. Even if the pull request introduced some new things (e.g. annotation tags), essentially they are just fixing this bug. I'll try to cherry-pick them and produce a 4.2.3 release if there's nothing against it.andreasprlic commentedon Jun 22, 2016
go for it... creating a release is now only pressing a button in our new Jenkins setup!
Fix #480. Correct spelling of _symmetry.space_group_name_H-M in CIF o…
sbliven commentedon Jun 23, 2016
Oops! Good catch, Jose. This is definitely an important fix for the 4.2 line.