You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Alternate conformations not rotated in AlignmentGUI #48
Alternate conformation don't get rotated during superposition for jMol display.
This bug accounts for how some molecules are uncentered in the display. They have side chains drifting at their old location that don't show up in a cartoon representation.
Example:
Align 1ax8 to 1alu (in that order). Residues 26, 30, and 117 of 1alu have alternate conformations.
I had a look at this. Since the "main" group now can contain references to atoms that are also in other altLocs this is making things a bit more complicated. We need an efficient lookup to verify if an atom is also in the main, otherwise there are too many calls to group.getAtoms().contains(), which can be very slow. Note: rotation and shift operations are called frequently as part of some algorithms, so this really needs to be very effective.
found a workaround. Rotations and shifts NEVER look at altlocs, but the code that prepares an alignment for display now makes sure that altLocs get correctly transformed.
Activity
andreasprlic commentedon Mar 13, 2014
I had a look at this. Since the "main" group now can contain references to atoms that are also in other altLocs this is making things a bit more complicated. We need an efficient lookup to verify if an atom is also in the main, otherwise there are too many calls to group.getAtoms().contains(), which can be very slow. Note: rotation and shift operations are called frequently as part of some algorithms, so this really needs to be very effective.
#48 altlocs are now getting rotated for display
andreasprlic commentedon Mar 13, 2014
found a workaround. Rotations and shifts NEVER look at altlocs, but the code that prepares an alignment for display now makes sure that altLocs get correctly transformed.
Merge pull request biojava#48 from ingokegel/master