Skip to content

Get representative Atoms from Structure different than from Chain #309

Closed

Description

@lafita

Calling:

StructureTools.getRepresentativeAtoms(Structure s)
Gives a different result than calling:

StructureTools.getRepresentativeAtoms(Chain c)

The first call returns an array of size 100 and the second an array of size 98 for 1hiv.A. The first method returns two Atoms more, corresponding to a modified residue CSO, in the middle of the array, and the ligand, at the end of the array. The ligand is 1ZK and has an Atom called CA.

This difference between the methods has caused some IndexOutOfBoundsExceptions when manipulating Atoms of a Structure. A solution could be using the chain method from the structure call. A Test and some test cases will be needed to make sure they are consistent.

Activity

  1. lafita commented on Aug 3, 2015

    @lafita
    MemberAuthor

    Another issue popped up: the ChemComp information is not being loaded correctly for HETATMs that are modified aminoacids (loaded as nulls and unknowns), like CSO or LLP, so they are not returned as part of the representative Atom array. This breaks some of the existing tests.

  2. andreasprlic commented on Aug 3, 2015

    @andreasprlic
    Member

    What ChemCompProvider are you using?

  3. lafita commented on Aug 4, 2015

    @lafita
    MemberAuthor

    The problem was in internal dependencies of the test. The cache for the ChemCompGroupFactory was not reset properly when the ChemCompProvider was set. I will create another issue regarding that and propose a fix. The differences between representative Atoms of chains and structures is fixed now.

  4. added a commit that references this issue on Aug 4, 2015
    6386177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions