Repository navigation
docs(release): record verified rc1 artifact set - #236
Conversation
📝 WalkthroughWalkthroughAdds documentation for the retained ChangesRelease documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7103527728
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Automated Codex coordinator queue record for the required final-head CodeRabbit walkthrough. This records provider state only; it is not a review or merge approval. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/release.md (1)
71-96: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winResolve the MD046 warnings for the installer examples.
markdownlint-cli2reports the four indented code blocks at Lines [73], [79], [85], and [91]. Convert them to fenced blocks compatible with the MkDocs tab syntax, or add a narrowly scoped lint exception.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/release.md` around lines 71 - 96, Update the four installer examples under the Linux, macOS (Apple silicon), macOS (Intel), and Windows PowerShell tabs to use fenced code blocks compatible with the existing MkDocs tab syntax, eliminating the MD046 warnings while preserving each command and language designation.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/release.md`:
- Around line 36-57: Update the “What a published Release contains” section to
distinguish the 13 uploaded project assets from the release’s 15 total assets,
explicitly identifying the two omitted GitHub-generated source archives. Clarify
that SHA256SUMS.txt covers the uploaded project assets and excludes those
generated archives, while preserving the existing 13-asset inventory and
recorded sizes.
- Around line 101-109: Update the attestation verification command in the
release documentation to include filters for the claimed workflow, tag, and
commit using --signer-workflow, --source-ref, and --source-digest. Ensure the
documented check accurately covers all four installers; otherwise explicitly
scope it to the Linux installer instead of implying coverage of all artifacts.
---
Nitpick comments:
In `@docs/release.md`:
- Around line 71-96: Update the four installer examples under the Linux, macOS
(Apple silicon), macOS (Intel), and Windows PowerShell tabs to use fenced code
blocks compatible with the existing MkDocs tab syntax, eliminating the MD046
warnings while preserving each command and language designation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Review-body MD046 nitpick validation for signed head
This evidence addresses the review-body nitpick; the overlapping Codex tab thread was replied to and resolved. No external review was triggered by this comment. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e85788f68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
Qualified release/domain review attestation (swarm-20260727T000627Z-1093f8): the authenticated maintainer approved exact PR head |
Summary
Closes #165.
This change records the retained
v1.0.0-rc1rehearsal in the existing release guide:SHA256SUMS.txtcovers the other 12 uploaded assets, not itself or the generated source archives;NOTICE; neither is a standalone RC1 upload;docs.ymlpublication.No workflow, tag, Release, signing setting, repository setting, dependency, or file outside
docs/release.mdchanges.Linked tracking
02a66a3bd8b64e698a3fb794fdca906ca84afbb27e85788f68f10d30de211dbd950bbf927e38f0e94783056297(automatic/best-effort; non-blocking)4783271042, run1ec6bb54-3436-460c-a230-d0c74590a1a2, on superseded head7103527728e509143976a9d93b00b117def831a7; all two major findings and the review-body nitpick were validated and addressed.183f928f-9863-4471-9aed-87ca313d1063was triggered by coordinator comment5087157203, completed in reply5087157697, reviewed the exact range02a66a3bd8b64e698a3fb794fdca906ca84afbb2…7e85788f68f10d30de211dbd950bbf927e38f0e9, and reported zero actionable findings.7e85788f68f10d30de211dbd950bbf927e38f0e9for qualified release/domain judgment; durable coordinator record: comment5092624432.7e85788f68f10d30de211dbd950bbf927e38f0e9; no remaining actionable findings.Evidence
v1.0.0-rc1, published 2026-07-21, still present and marked prerelease.SHA256SUMS.txt(1,112 bytes, SHA-256b54b05de939945185a933ea86d73cdf328038e138b267a13245b83fe7822ae54) lists exactly the other 12 uploaded assets and excludes the generated archives..github/workflows/release.yml,refs/tags/v1.0.0-rc1, and commit1ba112683a0f2a5ba842e39893fd757bff2d18b3.--signer-workflow,--source-ref, and--source-digestconstraints.LICENSEis staged as the constructorlicense_file; the rootNOTICEis not packaged.29791767414: tag verification, all fourbuild+signjobs, andpublish releaseconcluded successfully.docs.ymlhistory still contains only the two 2026-07-15 manual dispatches; no RC publication run exists.5029161546.Type of change
feat— new capabilityfix— bug fixdocs/chore/ci/build/refactor/test/perf!/BREAKING CHANGE:— a deliberate schema-version bumpSelf-review checklist (PRD §12.4)
docs/release.md; strict MkDocs is green.5092624432..tetherwrite.Testing
Current-head local evidence:
docs/release.mdwas the only changed file.pytest -p no:cacheprovider tests/test_marker_contract.py -q— 27 passed.pre-commit run --all-files --show-diff-on-failure— passed.QT_QPA_PLATFORM=offscreen pytest -p no:cacheprovider -m "not large and not sidecar and not deep" -q— 2,551 passed, 6 skipped, 34 deselected.UV_SYSTEM_CERTS=true uvx --with-requirements requirements-docs.txt mkdocs build --strict— passed.===tab markers.git diff --check— passed.Current-head hosted evidence:
183f928f-9863-4471-9aed-87ca313d1063completed on the exact current range with zero actionable findings.Author-side final diff review completed at
7e85788f68f10d30de211dbd950bbf927e38f0e9; no remaining actionable findings.Summary by CodeRabbit