This repository was archived by the owner on Feb 22, 2024. It is now read-only.
JSHint Refactoring - #4
Merged
Merged
Conversation
…x JSHint errors - replace new Array() with []
…reported by JSHint
Conflicts: Gruntfile.js src/javascript/pages/bet/bet_price.js src/javascript/utility.js
Conflicts: Gruntfile.js
Contributor
There was a problem hiding this comment.
Just curious why this was added? I see its for rollbar, just want to know the reason
Author
There was a problem hiding this comment.
I encountered an issue when this.chart.series was undefined.
But it didn't happen consistently.
So I decided adding a custom error in Rollbar, so we can identify it, was a good idea.
Once the cause is determined, I think a proper fix would be either just returning without telling Rollbar about it, or making sure the series property is never undefined.
Contributor
|
Seems fine to me overall, only concern is the strict comparison check as we may be depending on type equality check. Will test it however, even it fails we need to fix the code as problem will be in our implementation in that case |
Conflicts: Gruntfile.js
…e settings, reorganize
mohammad-deriv
referenced
this pull request
in mohammad-deriv/binary-static
Aug 22, 2016
mohammad-deriv
referenced
this pull request
in mohammad-deriv/binary-static
Aug 23, 2016
V20160531_0
mohammad-deriv
pushed a commit
that referenced
this pull request
May 21, 2018
fix issues with nativepicker
ashkanx
added a commit
that referenced
this pull request
Nov 8, 2018
easteregg
pushed a commit
to easteregg/binary-static
that referenced
this pull request
Apr 25, 2019
Add Unknown Icon
ashkanx
pushed a commit
that referenced
this pull request
Apr 26, 2019
Set granularity and chart type after clean the chart
4p00rv
pushed a commit
that referenced
this pull request
Mar 13, 2020
…er_image Add latest tag to docker image
matin-deriv
pushed a commit
to matin-deriv/binary-static
that referenced
this pull request
Apr 20, 2021
fiona-deriv
added a commit
to fiona-deriv/binary-static
that referenced
this pull request
Oct 5, 2021
fiona / remove metatrader/types-of-accounts page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes configure JSHint to be used as part of a build process.
Currently it is not included in the 'default' task, but probably should in very near future.
Travis, while full blown CI Server, is currently used to run the 'test' grunt task and not the full build task (this can change in future, or be left like this). Also, a test runner can be added to the 'test' task.
All of the changes are made in order to satisfy JSHint errors, and more future refactorings would be needed.
Also JSHint has some more options that can be enabled, but are kept off for now.
There are 12 more JSHint warnings (down from 345 in the beginning) that are not super obvious how to fix.
This is a good test for Travis too - it should be able to run the test, display the result, but show 'build failed' due to these.