Silence error if quick deploy is already enabled - #7
Merged
mpociot merged 2 commits intoApr 12, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR catches and silences an error returned by the Forge SDK after calling
forge config:pushif a quick deploy webhook already exists for the site.Yesterday this threw a
FailedActionExceptionbecause the error actually comes from GitHub, I emailed the Forge team about it and they're going to handle the error themselves. It looks like they may have already begun working on this since it now throws aValidationException. @jbrooksuk if you have a minute, do you know if this might change again? If it will, this PR should probably wait until that's finalized.Unrelated: fixed the wording of the deployment script warning message.