Dump deployment script as multi-line block - #19
Merged
mpociot merged 2 commits intoJun 11, 2021
Conversation
Member
|
Nice. I didn't know that flag! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Yaml::DUMP_MULTI_LINE_LITERAL_BLOCKso the deployment script is dumped as a multi-line string instead of an array of strings representing each line.Removes the visual noise of
- ''for blank lines, handles quotes a bit more nicely (doesn't need to escape them), and technically makes it so that the deploy script appears exactly as it does in Forge, including all formatting. Also, in my opinion at least, looks better.I added a check for an array when retrieving existing configs, so this should be completely backwards-compatible.
Before:
After: