Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sous-chefs/java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: bencaron/java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 5 files changed
  • 1 contributor

Commits on Aug 22, 2012

  1. Adding support for Windows flavour

    Benoit Caron committed Aug 22, 2012
    Configuration menu
    Copy the full SHA
    52adbcb View commit details
    Browse the repository at this point in the history

  2. Commented out an incomplete block of code 

    Commented out a check to cover the case of installing 32bit java
on 64 bit Windows: the path for java_home would change.

I did'nt know exactly how to check for that from node data and I
did'nt needed this anyway, but I've left the code to show where/how
that could be done.
    Benoit Caron committed Aug 22, 2012
    Configuration menu
    Copy the full SHA
    3f1a700 View commit details
    Browse the repository at this point in the history

  3. Added Windows as an option/recipe 

    I did not bumped up the version number, I'm leaving this for the
maintainer.
    Benoit Caron committed Aug 22, 2012
    Configuration menu
    Copy the full SHA
    d79c648 View commit details
    Browse the repository at this point in the history

  4. Adding some information about Windows usage

    Benoit Caron committed Aug 22, 2012
    Configuration menu
    Copy the full SHA
    67d4625 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2012

  1. package install is idempotent ; correct path setting 

    Uses the correct lwrp windows_path to set the PATH for java.

Find the installed java name from the parameter so that we can correctly
construct the name, which make the windows_package idempotent.
    Benoit Caron committed Sep 10, 2012
    Configuration menu
    Copy the full SHA
    c55c5f5 View commit details
    Browse the repository at this point in the history

  2. Ignore stuff

    Benoit Caron committed Sep 10, 2012
    Configuration menu
    Copy the full SHA
    f5e16e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2012

  1. Fix typo in windows java_home path

    Benoit Caron committed Sep 12, 2012
    Configuration menu
    Copy the full SHA
    b2d8cc1 View commit details
    Browse the repository at this point in the history
Loading