This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Repository navigation
Fix varargs in Python 2 files - #217
Merged
Merged
Conversation
Signed-off-by: Denys Smirnov <[email protected]>
Member
|
|
ncordon
approved these changes
Oct 14, 2019
ncordon
left a comment
ncordon
left a comment
Member
There was a problem hiding this comment.
Reviewed 1 of 5 files at r1.
Reviewable status: 1 of 5 files reviewed, all discussions resolved (waiting on @dennwc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Python 2 files varargs and kwargs in AST are strings and not objects as in Python 3 AST. We already fix kwargs to match Py3, but not varargs. This PR adds the same conversion for varargs as well.
Fixes #199
Signed-off-by: Denys Smirnov [email protected]
This change is